On Tue, Apr 07, 2009 at 07:01:14PM +0000, David Lutterkort wrote: > On Tue, 2009-04-07 at 16:50 +0100, Daniel P. Berrange wrote: > > The test impl needs to be within libvirt so it is always available no > > matter whether netcf is available for the build, so it shouldn't use > > netcf at all. > > For the time being though, netcf not being available also means that the > virInterface calls won't do anything with any other driver, since there > is no other driver impl. > > It makes more sense to me to use netcf during testing until there is a > different implementation of the virInterface API - at that point that > impl and the test driver will also be able to share a lot of code, so > that we don't have lots of test-only code. We certainly need a way to test netcf & the driver using it, but that's not what the 'test' driver in libvirt is for. It is solely for unit testing of libvirt driver internals, remote client, remote daemon and virsh, and end user applications. The test driver is intended to be entirely self contained, providing 'in-memory' implementations of the core API logic, and as such using netcf in any of this is not appropriate Functional testing of the netcf based driver is something that will be done separate from the test driver Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list