On Wed, May 04, 2016 at 07:41:58PM +0300, Roman Bogorodskiy wrote: > Currentt implementation of domainDestroy for bhyve calls > virProcessKillPainfully() for the bhyve process and then > executes "bhyvectl --destroy". > > This is wrong for two reasons: > > * bhyvectl --destroy alone is sufficient because it terminates > the process > * virProcessKillPainfully() first sends SIGTERM and after few > attempts sends SIGKILL. As SIGTERM triggers ACPI shutdown that > we're not interested in, it creates an unwatned side effect in > domainDestroy. > > Also, destroy monitor only after "bhyvectl --destroy" command succeeded > to avoid a case when the command fails and domain remains running, but > not being monitored anymore. > --- > src/bhyve/bhyve_process.c | 20 ++++++-------------- > 1 file changed, 6 insertions(+), 14 deletions(-) ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list