Re: [PATCH] vbox: VIR_WARN if we don't support the API version

[Laine Stump <laine@xxxxxxxxx>]

On 04/22/2016 05:59 PM, Cole Robinson wrote:
> We presently don't give any indication if the VirtualBox version
> isn't in our support whitelist.
> ---
>   src/vbox/vbox_common.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c
> index 0cead10..50ebdba 100644
> --- a/src/vbox/vbox_common.c
> +++ b/src/vbox/vbox_common.c
> @@ -7856,7 +7856,11 @@ virHypervisorDriverPtr vboxGetHypervisorDriver(uint32_t uVersion)
>       /* Install gVBoxAPI according to the vbox API version. */
>       int result = 0;
>       installUniformedAPI(gVBoxAPI, result);
> -    if (result < 0) return NULL;
> +    if (result < 0) {
> +        VIR_WARN(_("Libvirt doesn't support VirtualBox API version %u"),
> +                   uVersion);
> +        return NULL;
> +    }
>       updateDriver();
>       return &vboxCommonDriver;
>   }

I have no way of testing this, but an extra VIR_WARN certainly can't 
hurt anything. ACK.

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list