Re: [PATCH] qemu: Limit maximum block device I/O tune values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/21/2016 08:47 AM, Martin Kletzander wrote:
> The values are currently limited to LLONG_MAX which causes some
> problems.  QEMU conveniently changed their maximum to 1e15 (1 PB) which
> is enough for some time and we need to adapt to that so that we don't
> throw "Unknown error" messages.  Strictly limiting these values actually
> fixes some corner case values (off-by-one checks in QEMU probably).
> 
> Since values out of the new specified range do not overflow anything,
> change the type of error as well.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1317531
> 
> Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
> ---
>  src/qemu/qemu_command.c | 30 +++++++++++++++---------------
>  src/qemu/qemu_command.h |  2 ++
>  src/qemu/qemu_driver.c  |  6 +++---
>  3 files changed, 20 insertions(+), 18 deletions(-)
> 

ACK

- Cole

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]