Re: [PATCH] tools: Fix connect command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/21/2016 08:46 AM, Martin Kletzander wrote:
> The man page says: "(Re)-Connect to the hypervisor. When the shell is
> first started, this is automatically run with the URI parameter
> requested by the "-c" option on the command line."  However, if you run:
> 
>   virsh -c 'test://default' 'connect; uri'
> 
> the output will not be 'test://default'.  That's because the 'connect'
> command does not care about any virsh-only related settings and if it is
> run without parameters, it connects with @uri == NULL.  Not only that
> doesn't comply to what the man page describes, but it also doesn't make
> sense.  It also means you aren't able to reconnect to whatever you are
> connected currently.
> 
> So let's fix that in both virsh and virt-admin add a test case for it.
> 
> Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx>

FYI the tools/virsh.c bits will need to be reworked slightly ontop of the
other virsh connect patch I just pushed

- Cole

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]