On Wed, Apr 01, 2009 at 04:56:46PM +0100, Daniel P. Berrange wrote: > The Mingw platform lacks readlink(), so we stub out this method on that > platform. > > The plain write() implementation of safezero() was not actually doing > anything with the 'offset' arg. This makes it seek to the offset > location before writing data. > > The mmap implementation of safezero() was also not quite right, truncating > to len, so if offset was non-zero, it would not be large enough. Patch looks fine to me, ACK ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list