Re: [PATCH] network: Don't use ERR_NO_SUPPORT for invalid net-update requests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 19, 2016 at 17:34:51 -0400, Cole Robinson wrote:
> VIR_ERR_NO_SUPPORT maps to the error string
> 
>     this function is not supported by the connection driver
> 
> and is largely only used for when a driver doesn't have any
> implementation for a public API. So its usage with invalid
> net-update requests is a bit out of place. Instead use
> VIR_ERR_OPERATION_UNSUPPORTED which maps to:
> 
>     Operation not supported
> 
> And is what qemu's hotplug routines use in similar scenarios
> ---
>  src/conf/network_conf.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

ACK

Jirka

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]