Re: [PATCH] lxc: explicitly error on interface type=ethernet

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



ping

On 04/11/2016 10:56 AM, Cole Robinson wrote:
> It isn't implemented and does not work:
> 
> error: internal error: guest failed to start: /usr/lib/libvirt/libvirt_lxc: option '--veth' requires an argument
> syntax: /usr/lib/libvirt/libvirt_lxc [OPTIONS] ...
> 
> We previously threw an explicit error, but this changed in
> 22cff52a2b8e06c913b1f97767e5d390fb17fc3b , which I suspect was
> untested for LXC
> ---
>  src/lxc/lxc_process.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c
> index 5e0bbe2..0044ee5 100644
> --- a/src/lxc/lxc_process.c
> +++ b/src/lxc/lxc_process.c
> @@ -559,8 +559,6 @@ static int virLXCProcessSetupInterfaces(virConnectPtr conn,
>              break;
>  
>          case VIR_DOMAIN_NET_TYPE_ETHERNET:
> -            break;
> -
>          case VIR_DOMAIN_NET_TYPE_USER:
>          case VIR_DOMAIN_NET_TYPE_VHOSTUSER:
>          case VIR_DOMAIN_NET_TYPE_SERVER:
> 

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]