Re: [libvirt-php][PATCH 2/3] Fix some leaks related to get_string_from_xpath

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19.04.2016 16:48, Vasiliy Tolstov wrote:
> 2016-04-19 16:46 GMT+03:00 Michal Privoznik <mprivozn@xxxxxxxxxx>:
>> This function not only did not free return value of
>> xmlNodeListGetString() it strdup()-ed its return value. Therefore
>> plenty of memory has been lost definitely upon return from this
>> function.
> 
> 
> I don't think that this function need at all. I'm switching to get
> full xml of domain and doing xpath via native php code.
> 

Yeah, but I was just too lazy to do that :) If you can post a patch that
would be great! Any time estimate, e.g. should I postpone the release
for tomorrow?

Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]