Re: [PATCH 2/4] examples: Try harder to uninstall nwfilter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 04/19/2016 09:50 AM, Michal Privoznik wrote:
> We have this code in our Makefile that tries to remove
> /etc/libvirt/nwfilter if directory is left empty after all our
> example nwfilters were uninstalled. However, the check for that
> is missing quotation marks thus rendering the test useless:
> 
> test -z allow-arp.xml allow-dhcp-server.xml .. qemu-announce-self.xml || \
>   rmdir "/some/path/libvirt.git/_install/etc/libvirt/nwfilter"
> /bin/sh: line 0: test: too many arguments
> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  examples/Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

ACK

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]