On Sat, Apr 16, 2016 at 08:30:44AM -0400, John Ferlan wrote: > While working on the tests for the secret initialization vector, I found > that the existing iSCSI tests were lacking in how they defined the IQN. > Many had IQN's of just 'iqn.1992-01.com.example' for one disk while using > 'iqn.1992-01.com.example/1' for the second disk (same for hostdevs - guess > how they were copied/generated). > > Typically (and documented this way), IQN's would include be of the form > 'iqn.1992-01.com.example:storage/1' indicating an IQN using "storage" for > naming authority specific string and "/1" for the iSCSI LUN. > > So modify the input XML's to use the more proper format - this of course > has a ripple effect on the output XML and the args. > > Also note that the "%3A" is generated by the virURIFormat/xmlSaveUri > to represent the colon. > > Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx> > --- > .../qemuargv2xml-disk-drive-network-iscsi-auth.args | 6 +++--- > .../qemuargv2xml-disk-drive-network-iscsi-auth.xml | 4 ++-- > .../qemuxml2argv-disk-drive-network-iscsi-auth.args | 8 +++++--- > .../qemuxml2argv-disk-drive-network-iscsi-auth.xml | 7 +++++-- > .../qemuxml2argv-hostdev-scsi-lsi-iscsi-auth.args | 4 ++-- > .../qemuxml2argvdata/qemuxml2argv-hostdev-scsi-lsi-iscsi-auth.xml | 4 ++-- > .../qemuxml2argv-hostdev-scsi-virtio-iscsi-auth.args | 4 ++-- > .../qemuxml2argv-hostdev-scsi-virtio-iscsi-auth.xml | 4 ++-- > .../qemuxml2xmlout-disk-drive-network-iscsi-auth.xml | 7 +++++-- > .../qemuxml2xmlout-hostdev-scsi-lsi-iscsi-auth.xml | 4 ++-- > .../qemuxml2xmlout-hostdev-scsi-virtio-iscsi-auth.xml | 4 ++-- > 11 files changed, 32 insertions(+), 24 deletions(-) > ACK Jan -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list