Re: [PATCH v2] Include sysmacros.h where needed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 15, 2016 at 09:21:49 +0200, Martin Kletzander wrote:
> So in glibc-2.23 sys/sysmacros.h is no longer included from sys/types.h
> and we don't build because of the usage of major/minor/makedev macros.
> Autoconf already has AC_HEADER_MAJOR macro that check where exactly
> these functions/macros are defined, so let's use that.
> 
> Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
> ---
> v2:
>  - Don't include the file unconditionally, but rather use
>    AC_HEADER_MAJOR that exists for exactly this purpose.
> 
> v1:
>  - https://www.redhat.com/archives/libvir-list/2016-April/msg00851.html
> 
>  configure.ac             | 2 ++
>  src/conf/domain_audit.c  | 6 ++++++
>  src/lxc/lxc_controller.c | 7 +++++++
>  src/lxc/lxc_driver.c     | 7 +++++++
>  src/util/vircgroup.c     | 7 +++++++
>  src/util/virutil.c       | 7 +++++++
>  tests/vircgroupmock.c    | 7 +++++++
>  7 files changed, 43 insertions(+)

I've just found out about the breakage by upgrading glibc and almost
blamed you as I've misunderstood this patch.

This fixes the build for me and the usage of AC_HEADER_MAJOR looks on
the spot to me.

ACK

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]