Re: [PATCH 5/7] Add VIR_DOMAIN_EVENT_ID_DEVICE_REMOVAL_FAILED event

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 12, 2016 at 20:03:41 -0400, Cole Robinson wrote:
> On 04/05/2016 11:09 AM, Peter Krempa wrote:
> > Since we didn't opt to use one single event for device lifecycle for a
> > VM we are missing one last event if the device removal failed. This
> > event will be emitted once we asked to eject the device but for some
> > reason it is not possible.
> > ---
> >  daemon/remote.c                  | 36 +++++++++++++++++
> >  include/libvirt/libvirt-domain.h | 21 ++++++++++
> >  src/conf/domain_event.c          | 84 ++++++++++++++++++++++++++++++++++++++++
> >  src/conf/domain_event.h          |  7 ++++
> >  src/libvirt_private.syms         |  2 +
> >  src/remote/remote_driver.c       | 30 ++++++++++++++
> >  src/remote/remote_protocol.x     | 14 ++++++-
> >  src/remote_protocol-structs      |  6 +++
> >  tools/virsh-domain.c             | 18 +++++++++
> >  9 files changed, 217 insertions(+), 1 deletion(-)
> 
> ACK, I verified it largely mirrors DeviceAdded signal.

I largely inspired myself by DeviceAdded :)

> 
> event-test.c follow up patch?

gah I forgot. I'll follow up, looks like I'll refactor it prior to
adding the new stuff.

Thanks.

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]