On Tue, Mar 31, 2009 at 11:40:32AM +0200, Daniel Veillard wrote: > On Mon, Mar 30, 2009 at 02:10:05PM +0200, Chris Lalancette wrote: > > This patch converts the internal drivers to use the old-style struct > > initializers, which kind of gives us a self-documenting TODO list for each of > > the drivers. It also fixes up some bad comments in the internal driver list. > > It does not touch the storage or network driver initializers. > > Okay I agree that the ancient form is preferable, to me it allows > very easilly to spot missing features in the driver table (the > associated entry is NULL). Yes, that's the precise reason I have had this on my todo list. I really like being able to spot incomplete driver methods easily, and think that outweighs the other benefits of C99 style in this scenario. Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list