On Thu, Mar 31, 2016 at 08:29:52AM -0400, John Ferlan wrote:
On 03/30/2016 11:13 AM, Martin Kletzander wrote:For now, the test was dumping an XML of inactive domain (well, setting the id to '-1' to be precise) when checking the results. This patch enables future additions to test the live XML output as well. Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx> --- tests/qemuhotplugtest.c | 27 +++++++++++++++++---------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c index 1eb2b6a881f2..2b0de94fb4a6 100644 --- a/tests/qemuhotplugtest.c +++ b/tests/qemuhotplugtest.c @@ -371,7 +374,7 @@ mymain(void) /* wait only 100ms for DEVICE_DELETED event */ qemuDomainRemoveDeviceWaitTime = 100; -#define DO_TEST(file, ACTION, dev, event, fial, kep, ...) \ +#define DO_TEST(file, ACTION, dev, event, fial, kep, liv, ...) \"Typically" rather than misspelling "fail", "keep", or "live" one would use an underscore, such as "_fail", "_keep", and "_live" in order to represent a macro argument... Not required for ACK, but nice nonetheless
I didn't want to get to discussions about this so I followed what was already used in this file (and bunch of others as well). If I were to change this, it would go into separate patch anyway, so it doesn't make sense to change in this one, I believe.
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list