Re: [PATCH 18/18] qemu_domain: remove all listens if vncAutoUnixSocket is enabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/04/2016 09:20 AM, Pavel Hrdina wrote:
> If in qemu.conf vncAutoUnixSocket is enabled remove all other listens
> parsed from XML config.
> 
> Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx>

Sorry I should have read further before commenting on patch #15 :)

This isn't in line with how we handle qemu.conf vnc_listen, which is 'only use
the qemu.conf setting if the user doesn't specify any explicit <listen> config'

I think that's the more sensible behavior so I'd rather see the code fixed to
abide that instead. So, the change I suggested in patch #15, but maybe it
needs fixes elsewhere too

- Cole

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]