Re: [PATCH] qemu: Check for gnutls_rnd() explicitly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2016-04-07 at 13:57 +0200, Andrea Bolognani wrote:
> Our use of gnutls_rnd() is conditional to the availability of
> the <gnutls/crypto.h> header file.
> 
> Such check, however, turns out not to be strict enough as there
> are some versions of gnutls (eg. 2.8.5 as available in CentOS 6)
> that provide the header file, but not the function itself, which
> was introduced in 2.12.0.
> 
> Introduce an explicit check for the function itself.
> ---
> Would qualify as a build breaker (see [1]) but I'd rather have
> some feedback before pushing it.
> 
> [1] https://ci.centos.org/view/libvirt-project/job/libvirt-daemon-build/systems=libvirt-centos-6/1120/

SNACK

John pointed out that HAVE_GNUTLS_RND is never defined, so while
this technically still fixes the build breakage, it's not really
the patch we're looking for :)

I'll try to figure out how to make it work properly. Suggestions
are always welcome.

Cheers.

-- 
Andrea Bolognani
Software Engineer - Virtualization Team

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]