On Mon, Apr 04, 2016 at 10:19:58PM -0400, John Ferlan wrote:
> Commit id 'fb2bd208' essentially copied the qemuGetSecretString
> creating an libxlGetSecretString. Rather than have multiple copies
> of the same code, create src/secret/secret_util.{c,h} files and
> place the common function in there.
>
> Modify the the build in order to build the module as a library
> which is then pulled in by both the qemu and libxl drivers for
> usage from both qemu_command.c and libxl_conf.c
>
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
>
> My Makefile.am skills are weak at best - not sure I got it totally
> right, but I think I'm at least close (it builds and links).
>
> po/POTFILES.in | 1 +
> src/Makefile.am | 17 ++++++-
> src/libvirt_private.syms | 4 ++
> src/libxl/libxl_conf.c | 82 +++-----------------------------
> src/qemu/qemu_command.c | 87 ++++------------------------------
> src/secret/secret_util.c | 120 +++++++++++++++++++++++++++++++++++++++++++++++
> src/secret/secret_util.h | 35 ++++++++++++++
> 7 files changed, 190 insertions(+), 156 deletions(-)
> create mode 100644 src/secret/secret_util.c
> create mode 100644 src/secret/secret_util.h
>
ACK
Jan
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list