Re: [PATCH] Pass the correct cpu count when calling virDomainGetCPUStats.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 01, 2016 at 02:05:04AM -0400, Nitesh Konkar wrote:
> When using the --start option, the show_count should not be set to
> max_id as the --start <cpu> means we dont need those many inital cpu
> stats. Hence, show_count should be adjusted accordingly.
> 

There is a public bug filed for this:
https://bugzilla.redhat.com/show_bug.cgi?id=1249441

I have added the link to the commit message.

> Signed-off-by: Nitesh Konkar <nitkon12@xxxxxxxxxxxxxxxxxx>
> ---
> Before Patch:
> virsh cpu-stats --domain 24 --start 158
> CPU158:
> cpu_time             0.073570788 seconds
> vcpu_time            0.033277032 seconds
> 
> CPU159:
> cpu_time             0.000000000 seconds
> vcpu_time            0.000000000 seconds
> error: Failed to retrieve CPU statistics for domain 24
> error: invalid argument: start_cpu 280 larger than maximum of 159
> 
> After Patch:
> virsh cpu-stats --domain 24 --start 158
> CPU158:
> cpu_time             0.073570788 seconds
> vcpu_time            0.033277032 seconds
> 
> CPU159:
> cpu_time             0.000000000 seconds
> vcpu_time            0.000000000 seconds
> 
>  tools/virsh-domain.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

ACK and pushed

Jan

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]