On Wed, Mar 25, 2009 at 02:16:48PM -0400, Laine Stump wrote: > (Oops, I originally sent this with the wrong return address, which > probably caused it to be silently swallowed...) [...] Dan replied to most points, and raised the main problems > As before, any and all advice/corrections gratefully accepted! > +/* > + * Define interface (or modify existing interface configuration) > + */ > +virInterfacePtr virInterfaceDefineXML (virConnectPtr conn, > + const char *xmlDesc); I would add an extra "unsigned int flags" as the last parameter, unused for now > +/* > + * Delete interface > + */ > +int virInterfaceUndefine (virInterfacePtr interface); > + > +/* > + * Activate interface (ie call "ifup") > + */ > +int virInterfaceStart (virInterfacePtr interface); Same for the Create() one per Dan's suggested renaming. > + > +/* > + * De-activate interface (call "ifdown") > + */ > +int virInterfaceStop (virInterfacePtr interface); For Stop/Destroy, my preference in naming would go to Delete, and also add an unsigned int flags argument. Thanks :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list