On Tue, Mar 24, 2009 at 11:16:38AM +0000, Daniel P. Berrange wrote: > On Fri, Mar 20, 2009 at 03:34:44PM +0100, Soren Hansen wrote: > > In libvirt 0.6.1, if you create a domain description of type 'kvm' > > without an arch set on an x86-64 host, you would get an i686 qemu guest > > rather than the expected x86-64 kvm guest. > > > > This is because virCapabilitiesDefaultGuestArch doesn't take the domain > > type into consideration, so it just returned the first hvm architecutre > > that has been registered, which is i686. > > > > After applying Dan P's patch, > > > > http://www.redhat.com/archives/libvir-list/2009-March/msg00281.html, > > > > I now get a i686 kvm guest, since kvm now can do i686 guests from > > libvirt. This is certainly an improvement, but I think a more reasonable > > default is to attempt to match the host's architecture. > > > > This patch makes virCapabilitiesDefaultGuestArch also check the domain > > type, and also gives preference to a guest architecture that matches the > > host's architecture. > > I've committed this patch now Sorry I nearly did it yesterday when I got distrated and didn't push/mail about it, fine, thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list