On Fri, Mar 18, 2016 at 10:25:58AM +0100, Ján Tomko wrote:
> > - if (graphics->data.spice.playback)
> > - virBufferAsprintf(&opt, ",playback-compression=%s",
> > + }
> > + if (graphics->data.spice.playback) {
> > + virBufferAsprintf(&opt, "playback-compression=%s,",
> > virTristateSwitchTypeToString(graphics->data.spice.playback));
> > - if (graphics->data.spice.streaming)
> > - virBufferAsprintf(&opt, ",streaming-video=%s",
> > + }
> > + if (graphics->data.spice.streaming) {
> > + virBufferAsprintf(&opt, "streaming-video=%s,",
> > virDomainGraphicsSpiceStreamingModeTypeToString(graphics->data.spice.streaming));
> > - if (graphics->data.spice.copypaste == VIR_TRISTATE_BOOL_NO)
> > - virBufferAddLit(&opt, ",disable-copy-paste");
> > + }
> > + if (graphics->data.spice.copypaste == VIR_TRISTATE_BOOL_NO) {
> > + virBufferAddLit(&opt, "disable-copy-paste,");
> > + }
>
> This breaks make syntax-check:
>
> Curly brackets around single-line body:
> src/qemu/qemu_command.c:7559-7561:
> if (graphics->data.spice.copypaste == VIR_TRISTATE_BOOL_NO) {
> virBufferAddLit(&opt, "disable-copy-paste,");
> }
Ah thanks, I'll make sure to fix these before pushing. Totally forgot to
rerun it before sending v2.
Christophe
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list