Re: [PATCH 1/6] rbd: Use proper error type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



  Richard Laager wrote:

> ---
>  src/storage/storage_backend_rbd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c
> index 7d04b39..3e70a42 100644
> --- a/src/storage/storage_backend_rbd.c
> +++ b/src/storage/storage_backend_rbd.c
> @@ -671,9 +671,9 @@ virStorageBackendRBDCreateVol(virConnectPtr conn ATTRIBUTE_UNUSED,
>      vol->type = VIR_STORAGE_VOL_NETWORK;
>  
>      if (vol->target.format != VIR_STORAGE_FILE_RAW) {
> -        virReportError(VIR_ERR_NO_SUPPORT, "%s",
> +        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
>                         _("only RAW volumes are supported by this storage pool"));
> -        return -VIR_ERR_NO_SUPPORT;
> +        return -1;
>      }
>  
>      VIR_FREE(vol->target.path);

ACK the series except the patch 4/6, because I'm not very familiar with
the logical backend (or lvm itself to be exact), so it would be great is
somebody could take a look at it.  

Roman Bogorodskiy

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]