Re: [PATCH] qemuBuildVideoCommandLine: Don't access def->videos without check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 14, 2016 at 09:47:05 +0100, Michal Privoznik wrote:
> This function can be called over a domain definition that has no
> video configured. The
> tests/qemuxml2argvdata/qemuxml2argv-minimal.xml file could serve
> as an example. Problem is, before the check that domain has some
> or none video configured, def->videos is dereferenced causing a
> segmentation fault in case there's none video configured.

Caused by commit 95ca4fe2

> 
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  src/qemu/qemu_command.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

ACK

Peter

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]