On Mon, 2016-03-07 at 21:57 -0500, Laine Stump wrote: > On 03/07/2016 12:24 PM, Andrea Bolognani wrote: > > > > Instead of considering each single step its own test case, create > > high level test cases that reproduce a certain scenario. > > --- > > tests/virhostdevtest.c | 119 ++++++++++++++++++++++++++++++++++++++++--------- > > 1 file changed, 97 insertions(+), 22 deletions(-) > I like the idea, just have two comments: > > 1) would it maybe be useful to keep the individual tests, in order to > make it simpler to determine which piece had broken in the case of a > regression? If some test case fails you're probably going to be using VIR_TEST_DEBUG, gdb or a combination of the two to figure out what went wrong, so I'm not convinced testing the functions separately would add much value. > 2) It looks like this only tests for legacy kvm (i.e. > attaching/detaching pci-stub). It would be good to have it test for vfio > as well (although maybe that can be saved for after we add support for > using individual devices' driver_override to attach different drivers). Sure, adding more test cases is always good :) I'm not sure what this driver_override you refer to is supposed to be though, care to expand on that? > ACK as is, the comments are food for thought. Pushed along with the rest. Cheers. -- Andrea Bolognani Software Engineer - Virtualization Team -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list