Re: [PATCH 6/7] virNetworkDefForwardIf: drop inline

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 03, 2016 at 09:44:41AM +0100, Michal Privoznik wrote:
In file included from network/bridge_driver_platform.h:30:0,
                from network/bridge_driver_platform.c:26:
network/bridge_driver_linux.c: In function 'networkRemoveRoutingFirewallRules':
./conf/network_conf.h:350:1: error: inlining failed in call to 'virNetworkDefForwardIf.constprop': call is unlikely and code size would grow [-Werror=inline]
virNetworkDefForwardIf(const virNetworkDef *def, size_t n)
^
Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

Double sign-off;

not only drop inline, but make it as non-static function.  To those that
might wonder why isn't only the static keyword removed, that doesn't
work, I tried it, but I cannot explain it.  This is the same patch I
came up with, except the double sign-off ;)

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]