On Wed, Feb 17, 2016 at 03:14:54PM +0300, Nikolay Shirokovskiy wrote: > Make register and unregister functions return void because > we can check the state of callback object beforehand via > virConnectCloseCallbackDataGetCallback. This can be done > without race conditions if we use higher level locks for registering > and unregistering. The fact they return void simplifies > task of consistent registering/unregistering. > > Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@xxxxxxxxxxxxx> > --- > src/datatypes.c | 80 ++++++++++++++++++++++++++++++++++++++++++++++ > src/datatypes.h | 12 +++++++ > src/libvirt-host.c | 29 +++-------------- > src/remote/remote_driver.c | 17 ++-------- > 4 files changed, 99 insertions(+), 39 deletions(-) ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list