Re: [PATCHv2 0/3] reorder qemu cgroups operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 26, 2016 at 04:34:21PM +0100, Henning Schild wrote:
> This is a much shorter series focusing on the key point, the second patch.
> The first patch is somehing that was found when looking at the code and is
> just a cosmetic change. The third patch just cleans up. They where both
> already ACKed.
> 
> Patch 2 was also already ACKed but conflicted with another pending change.
> It should be reviewed in its new context. Note the new order with the
> "manual" affinity setting code.
> 
> @Peter:
> qemuProcessInitCpuAffinity and qemuProcessSetupEmulator have a lot in
> in common. I guess there is potential for further simplification.
> 
> The series is based on 92ec2e5e9b79b7df4d575040224bd606ab0b6dd8 with
> these two patches on top:
> http://www.redhat.com/archives/libvir-list/2016-February/msg01211.html
> 
> Henning Schild (3):
>   vircgroup: one central point for adding tasks to cgroups
>   qemu_cgroup: put qemu right into emulator sub-cgroup
>   qemu_cgroup: use virCgroupAddTask instead of virCgroupMoveTask
> 
>  src/libvirt_private.syms |   1 -
>  src/qemu/qemu_process.c  |  10 ++---
>  src/util/vircgroup.c     | 105 +----------------------------------------------
>  src/util/vircgroup.h     |   3 --
>  4 files changed, 6 insertions(+), 113 deletions(-)

ACK to all three, but we should probably wait until after release freeze
is over to push this.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]