Enable GIR warnings and fix them, since they are all useful.
Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxx>
---
libvirt-gconfig/Makefile.am | 1 +
libvirt-glib/Makefile.am | 1 +
libvirt-gobject/Makefile.am | 1 +
libvirt-gobject/libvirt-gobject-connection.c | 2 +-
libvirt-gobject/libvirt-gobject-domain.c | 2 +-
libvirt-gobject/libvirt-gobject-network.c | 1 -
libvirt-gobject/libvirt-gobject-stream.c | 3 +--
7 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/libvirt-gconfig/Makefile.am b/libvirt-gconfig/Makefile.am
index 77b2032..f308539 100644
--- a/libvirt-gconfig/Makefile.am
+++ b/libvirt-gconfig/Makefile.am
@@ -263,6 +263,7 @@ LibvirtGConfig_1_0_gir_SCANNERFLAGS = \
--identifier-prefix=GVirConfig \
--symbol-prefix=gvir_config \
--c-include="libvirt-gconfig/libvirt-gconfig.h" \
+ --warn-all \
$(NULL)
INTROSPECTION_GIRS += LibvirtGConfig-1.0.gir
diff --git a/libvirt-glib/Makefile.am b/libvirt-glib/Makefile.am
index a48cfbb..12a390f 100644
--- a/libvirt-glib/Makefile.am
+++ b/libvirt-glib/Makefile.am
@@ -67,6 +67,7 @@ LibvirtGLib_1_0_gir_SCANNERFLAGS = \
--identifier-prefix=GVir \
--symbol-prefix=gvir \
--c-include="libvirt-glib/libvirt-glib.h" \
+ --warn-all \
$(NULL)
INTROSPECTION_GIRS += LibvirtGLib-1.0.gir
diff --git a/libvirt-gobject/Makefile.am b/libvirt-gobject/Makefile.am
index 8464f04..5e130ee 100644
--- a/libvirt-gobject/Makefile.am
+++ b/libvirt-gobject/Makefile.am
@@ -160,6 +160,7 @@ LibvirtGObject_1_0_gir_SCANNERFLAGS = \
--c-include="libvirt-gobject/libvirt-gobject.h" \
--include-uninstalled $(top_builddir)/libvirt-glib/LibvirtGLib-1.0.gir \
--include-uninstalled $(top_builddir)/libvirt-gconfig/LibvirtGConfig-1.0.gir \
+ --warn-all \
$(NULL)
INTROSPECTION_GIRS += LibvirtGObject-1.0.gir
INTROSPECTION_COMPILER_ARGS = \
diff --git a/libvirt-gobject/libvirt-gobject-connection.c b/libvirt-gobject/libvirt-gobject-connection.c
index 61ae364..00d5eda 100644
--- a/libvirt-gobject/libvirt-gobject-connection.c
+++ b/libvirt-gobject/libvirt-gobject-connection.c
@@ -1681,7 +1681,7 @@ GVirInterface *gvir_connection_get_interface(GVirConnection *conn,
/**
* gvir_connection_find_interface_by_mac:
* @conn: a #GVirConnection
- * @mac: MAC address to lookup
+ * @macaddr: MAC address to lookup
*
* Get a particular interface which has MAC address @mac.
*
diff --git a/libvirt-gobject/libvirt-gobject-domain.c b/libvirt-gobject/libvirt-gobject-domain.c
index 7bb3b13..7be936d 100644
--- a/libvirt-gobject/libvirt-gobject-domain.c
+++ b/libvirt-gobject/libvirt-gobject-domain.c
@@ -1824,7 +1824,7 @@ gboolean gvir_domain_get_has_current_snapshot(GVirDomain *dom,
* @dom: the domain
* @date_time: (allow-none)(transfer none): the time to set as #GDateTime.
* @flags: Unused, pass 0.
- * @error: (allow-none): Place-holder for error or %NULL
+ * @err: (allow-none): Place-holder for error or %NULL
*
* This function tries to set guest time to the given value. The passed
* time must in UTC.
diff --git a/libvirt-gobject/libvirt-gobject-network.c b/libvirt-gobject/libvirt-gobject-network.c
index 0dd80a5..0129a73 100644
--- a/libvirt-gobject/libvirt-gobject-network.c
+++ b/libvirt-gobject/libvirt-gobject-network.c
@@ -229,7 +229,6 @@ GVirConfigNetwork *gvir_network_get_config(GVirNetwork *network,
* @network: the network
* @mac: (allow-none): The optional ASCII formatted MAC address of an interface
* @flags: placeholder for flags, must be 0
- *
* @err: Place-holder for possible errors
*
* This function fetches leases info of guests in the specified network. If the
diff --git a/libvirt-gobject/libvirt-gobject-stream.c b/libvirt-gobject/libvirt-gobject-stream.c
index 03a0308..a518a19 100644
--- a/libvirt-gobject/libvirt-gobject-stream.c
+++ b/libvirt-gobject/libvirt-gobject-stream.c
@@ -679,7 +679,7 @@ guint gvir_stream_add_watch(GVirStream *stream,
}
/**
- * gvir_stream_add_watch_full:
+ * gvir_stream_add_watch_full: (rename-to gvir_stream_add_watch)
* @stream: the stream
* @priority: the priority of the #GVirStream source
* @cond: the conditions to watch for (bitfield of #GVirStreamIOCondition)
@@ -690,7 +690,6 @@ guint gvir_stream_add_watch(GVirStream *stream,
* Adds a watch for @stream to the mainloop
*
* Returns: the event source id
- * Rename to: gvir_stream_add_watch
*/
guint gvir_stream_add_watch_full(GVirStream *stream,
gint priority,
--
2.5.0
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list