[PATCH v2 0/4] cleanup resolving persistent/running/current flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Original name of series was:
Subject: [PATCH 0/3] make virDomainObjGetPersistentDef return only persistent definition

Changes from version1
=====================

Original motivation of the series was fixing virDomainObjGetPersistentDef so
that it would not return configs other than persistent. However the final patch
that does it in the first version is absent in current version. I think the
fix should be done another way and in different series. Thus this version has
only misc cleanups which are better splitted into patches in this version.

A few words why I leave patch for virDomainObjGetPersistentDef. First I should
not return NULL from the function as this value already has different meaning
 - memory allocation error and there is code that checks for this error. This
code calls virDomainObjGetPersistentDef unconditionally but later use the
return value only for persistent domains, thus it could get NULL pointer on
function call and treat it as an allocation error.

I think the proper way would be chaning virDomainObjGetPersistentDef so it
could not fail that is not call virDomainObjSetDefTransient. Looks like this
is already true because drivers that distiguish between running/persistent
config call virDomainObjSetDefTransient ealy in the domain start process (and
even two times) so that later calls for virDomainObjSetDefTransient are
unnecessary.

Nikolay Shirokovskiy (4):
  virDomainObjUpdateModificationImpact: reduce nesting
  libxlDomainSetMemoryFlags : reuse virDomainLiveConfigHelperMethod
  lxc, libxl: reuse virDomainObjUpdateModificationImpact
  libxlDomainPinVcpuFlags: remove check duplicates

 src/conf/domain_conf.c   |  12 +++---
 src/libxl/libxl_driver.c | 103 ++++-------------------------------------------
 src/lxc/lxc_driver.c     |  75 +++-------------------------------
 3 files changed, 19 insertions(+), 171 deletions(-)

-- 
1.8.3.1

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]