On 19.02.2016 15:30, Marc-André Lureau wrote: > Add Spice graphics gl attribute. qemu 2.6 should have -spice gl=on argument to > enable opengl rendering context (patches on the ML). This is necessary to > actually enable virgl rendering. > > Add a qemuxml2argv test for virtio-gpu + spice with virgl. > > Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx> > --- > docs/formatdomain.html.in | 8 ++++ > docs/schemas/domaincommon.rng | 8 ++++ > src/conf/domain_conf.c | 26 ++++++++++++- > src/conf/domain_conf.h | 1 + > src/qemu/qemu_capabilities.c | 2 + > src/qemu/qemu_capabilities.h | 1 + > src/qemu/qemu_command.c | 13 +++++++ > tests/qemucapabilitiesdata/caps_2.6.0-1.caps | 1 + > tests/qemucapabilitiesdata/caps_2.6.0-1.replies | 4 ++ > .../qemuxml2argv-video-virtio-gpu-spice-gl.args | 24 ++++++++++++ > .../qemuxml2argv-video-virtio-gpu-spice-gl.xml | 38 ++++++++++++++++++ > tests/qemuxml2argvtest.c | 6 +++ > .../qemuxml2xmlout-video-virtio-gpu-spice-gl.xml | 45 ++++++++++++++++++++++ > tests/qemuxml2xmltest.c | 1 + > 14 files changed, 177 insertions(+), 1 deletion(-) > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-virtio-gpu-spice-gl.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-virtio-gpu-spice-gl.xml > create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-video-virtio-gpu-spice-gl.xml Looking good. ACK to the design. But I'd rather postpone pushing until qemu has released the feature. Otherwise we may end up with different functionality we claim to be supported than qemu does. Yet again. Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list