On Wed, Feb 17, 2016 at 05:33:43PM -0700, Jim Fehlig wrote: > The most formal form of xl disk configuration uses key=value > syntax to define each configuration item, e.g. > > format=raw, vdev=xvda, access=rw, backendtype=phy, target=disksrc > > Change the xl disk formatter to produce this syntax, which allows > target= to contain meta info needed to setup a network-based > disksrc (e.g. rbd, nbd, iscsi). For details on xl disk config > format, see $xen-src/docs/misc/xl-disk-configuration.txt > > Update the disk config in the tests to use the formal syntax. > But add tests to ensure disks specified with the positional > parameter syntax are correctly converted to <disk> XML. > > Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxx> > --- > src/xenconfig/xen_xl.c | 27 ++++++----- > .../test-disk-positional-parms-full.cfg | 26 +++++++++++ > .../test-disk-positional-parms-full.xml | 54 ++++++++++++++++++++++ > .../test-disk-positional-parms-partial.cfg | 26 +++++++++++ > .../test-disk-positional-parms-partial.xml | 54 ++++++++++++++++++++++ > .../test-fullvirt-direct-kernel-boot.cfg | 2 +- > tests/xlconfigdata/test-fullvirt-multiusb.cfg | 2 +- > tests/xlconfigdata/test-new-disk.cfg | 2 +- > tests/xlconfigdata/test-paravirt-cmdline.cfg | 2 +- > tests/xlconfigdata/test-paravirt-maxvcpus.cfg | 2 +- > tests/xlconfigdata/test-spice-features.cfg | 2 +- > tests/xlconfigdata/test-spice.cfg | 2 +- > tests/xlconfigdata/test-vif-rate.cfg | 2 +- > tests/xlconfigtest.c | 2 + > 14 files changed, 186 insertions(+), 19 deletions(-) > ACK Jan -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list