Re: [PATCH] Miscellaneous for-loop syntax clean-ups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 22, 2016 at 12:15:14PM +0100, Michal Privoznik wrote:
On 22.02.2016 11:29, Martin Kletzander wrote:
Checking whether x > 0 before looping over [0..x] items doesn't make
sense and multi-line body must have curly brackets around it.

Best viewed with '-w'.

Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
---
 src/conf/domain_conf.c            | 24 +++++++++++++-------
 src/qemu/qemu_capabilities.c      | 30 ++++++++++++------------
 src/storage/storage_backend_rbd.c | 48 +++++++++++++++++++--------------------
 src/vbox/vbox_common.c            | 14 ++++--------
 4 files changed, 58 insertions(+), 58 deletions(-)

ACK

I wonder if we can use Coccinelle to find other occurrences of this pattern.


I did that, but we have no place for such files and I'm not sure we want
them in the repo, so I just use it all by myself.  I'd be happy to share
those, though =)

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]