On 22/02/16 08:57, Michal Privoznik wrote:
> There's a check if a domain definition has any graphics card and
> if so, we iterate over each one of them. This makes no sense,
> because even if it has none we can still iterate over.
>
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
> src/conf/domain_conf.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index e47d613..56bd1aa 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -22363,11 +22363,9 @@ virDomainDefFormatInternal(virDomainDefPtr def,
> goto error;
> }
>
> - if (def->ngraphics > 0) {
> - for (n = 0; n < def->ngraphics; n++)
> - if (virDomainGraphicsDefFormat(buf, def->graphics[n], flags) < 0)
> - goto error;
> - }
> + for (n = 0; n < def->ngraphics; n++)
> + if (virDomainGraphicsDefFormat(buf, def->graphics[n], flags) < 0)
> + goto error;
>
> for (n = 0; n < def->nsounds; n++)
> if (virDomainSoundDefFormat(buf, def->sounds[n], flags) < 0)
>
ACK
Erik
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list