On Thu, Feb 18, 2016 at 17:39:08 +0100, Marc-André Lureau wrote: > Add Spice graphics gl attribute. qemu 2.6 should have -spice gl=on argument to > enable opengl rendering context (patches on the ML). This is necessary to > actually enable virgl rendering. > > Add a qemuxml2argv test for virtio-gpu + spice with virgl. > > Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx> ... And another small issue: > diff --git a/tests/qemucapabilitiesdata/caps_2.5.0-1.caps b/tests/qemucapabilitiesdata/caps_2.5.0-1.caps > index 931bc4f..679d65a 100644 > --- a/tests/qemucapabilitiesdata/caps_2.5.0-1.caps > +++ b/tests/qemucapabilitiesdata/caps_2.5.0-1.caps > @@ -172,4 +172,5 @@ > <flag name='ich9-disable-s4'/> > <flag name='vserport-change-event'/> > <flag name='virtio-balloon-pci.deflate-on-oom'/> > + <flag name='spice-gl'/> > </qemuCaps> > diff --git a/tests/qemucapabilitiesdata/caps_2.5.0-1.replies b/tests/qemucapabilitiesdata/caps_2.5.0-1.replies > index 7b692b5..07aadba 100644 > --- a/tests/qemucapabilitiesdata/caps_2.5.0-1.replies > +++ b/tests/qemucapabilitiesdata/caps_2.5.0-1.replies > @@ -3345,6 +3345,10 @@ > { > "parameters": [ > { > + "name": "gl", > + "type": "boolean" > + }, > + { > "name": "seamless-migration", > "type": "boolean" > }, spice-gl should not be artificially included in QEMU 2.5.0 capabilities, you should add files describing real QEMU 2.6.0. Jirka -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list