On 02/17/2016 03:36 PM, Laine Stump wrote: > On 02/17/2016 12:17 PM, Cole Robinson wrote: >> PostParse handles it for us now. >> >> This causes some test suite churn; qemu's custom PostParse could is >> now invoked before the generic AddImplicitControllers, so PCI >> controllers end up sequentially in the XML before the generically >> added IDE controllers. So it's just some XML reordering >> --- > > I'm curious why you did this as a separate patch from 1/3. Of course calling > it an extra time is just a NOP so leaving them separate isn't going to make > anything break in a bisect, but I don't see the need for it. > I wanted to separate harmless test churn from potentially-impactful-but-probably-not xen test churn > At any rate, ACK. Thanks, I'll push these after patch #1 is ACKd - Cole -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list