Figure I'll do these in smaller chunks - it's a large module. Suffice to say there's a lot of "movement" and patches for each is tedius, but I hope in the end it will be easier to deal with. For the most part all patches are primarily code motion, although git diff may have you believe otherwise. Essentially, I'm starting at the top of qemuBuildCommandLine and working my way through either moving functions in a top down order from the beginning of the module or more usually creating a qemuBuildXXXXCommandLine function and calling it from the main processing code. I did not "manage" any of the QEMU_CAPS_DEVICE changes (e.g, remove code), but I could while I'm at if that's desired. Hopefully not many people are touching this module right now ;-)! John Ferlan (10): qemu: Move qemuDeviceDriveHostAlias qemu: Remove local emulator qemu: Make basic upfront checks before creating command qemu: Reorganize -machine arguments qemu: Reorganize -cpu arguments qemu: Reorganize qemuBuildDomainLoaderCommandLine call qemu: Reorganize -m arguments qemu: Reorganize -smp argument qemu: Reorganize IOThread -object arguments qemu: Reorganize -numa arguments src/qemu/qemu_alias.c | 16 + src/qemu/qemu_alias.h | 4 + src/qemu/qemu_command.c | 9010 ++++++++++++++++++++++++----------------------- src/qemu/qemu_command.h | 3 - src/qemu/qemu_hotplug.c | 6 +- 5 files changed, 4583 insertions(+), 4456 deletions(-) -- 2.5.0 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list