On Mon, Feb 15, 2016 at 11:22:27PM +0100, Matthias Bolte wrote: > 2016-02-11 12:59 GMT+01:00 Richard W.M. Jones <rjones@xxxxxxxxxx>: > > Is calling SessionIsActive necessary? From my (very limited) > > understanding, it seems as if we might use 'SessionManager. > > currentSession' property instead, which doesn't require admin > > permissions. Actually the code [see link above] already does this > > when ctx->hasSessionIsActive is false, but that doesn't apply to > > modern vCenter. > > SessionIsActive Is not necessary here, but it seemed to be the better > solution compared to this more hacky way of checking session object. I > wasn't aware that is would require admin level privileges. The patch works fine for me. I believe the server I'm testing against is vCenter 5.5, although I'm not totally sure about that. ACK. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list