Re: [PATCH 5/7] qemu: Always enable GIC on ARM virt machines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2016-02-09 at 09:30 -0500, John Ferlan wrote:
> So let's see that means the original patches should be fine with the
> following adjustments:
> 
> patch 1 has a typo in the commit message, then ACK
> patch 4 could change the function name (use Enable)
> patch 4 should use void instead of int for that function, then ACK
> 
> If we can add an xml2xml test that would help ensure something doesn't
> mess this up for the future.
> 
> I feel those type changes are simple enough to not need a new series
> posted.

I have addressed these comments and pushed the series; the
documentation update you recommended will be prepared and posted
shortly.

Cheers.

-- 
Andrea Bolognani
Software Engineer - Virtualization Team

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]