Re: [PATCH 08/12] qemu-command: Move qemuDomain*Address* functions to qemu_domain.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 15, 2016 at 02:37:22PM -0500, John Ferlan wrote:
> Move the functions into qemu_domain.c - additionally move any supporting
> static functions.
> 
> Make qemuDomainSupportsPCI non static.
> 
> Also, move and rename the following:
> 
> qemuSetSCSIControllerModel to qemuDomainSetSCSIControllerModel
> qemuCollectPCIAddress to qemuDomainCollectPCIAddress
> qemuValidateDevicePCISlotsPIIX3 to qemuDomainValidateDevicePCISlotsPIIX3
> qemuAssignDevicePCISlots to qemuDomainAssignDevicePCISlots
> 

Most of these deal with domain addresses and qemu_domain.c is growing
pretty large. I think they deserve a qemu_domain_addr.c module. (On the
other hand, strictly sticking to the qemuDomainAddr prefix will make the
function names too long)

Jan

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]