On Mon, 02/15 15:34, Peter Xu wrote: > On Mon, Feb 15, 2016 at 12:54:57AM -0600, Wei Huang wrote: > > On 2/13/16 23:41, Peter Xu wrote: > > > One question: how should I make this command "ARM only"? I see that > > > in qmp-commands.hx, I can use something like "#if defined > > > TARGET_ARM" to block out ARM specified commands, however how should > > > I do the similiar thing in qapi-schema.json? > > > > This situation is similar to "rtc-reset-reinjection", right? I think You > > can disable this feature on other arch's by setting > > QERR_FEATURE_DISABLED in file like monitor.c. > > Yes. Will include this when post the real patches. Yes, I think returning an error for non-ARM targets suffices. Fam -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list