Re: [PATCH 3/4] storageVolCreateXML: Swap order of two operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 10/02/16 17:28, Michal Privoznik wrote:
> Firstly, we realloc internal list to hold new item (=volume that
> will be potentially be created) and then we check whether we

s/\(potentially\)\@<= be//

If I screwed up the positive lookbehind just remove the second "be" :)

> actually know how to create it. If we don't we consume more
> memory than we really need for no good reason.
>
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  src/storage/storage_driver.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
...
ACK

Erik

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]