On Mon, Mar 09, 2009 at 01:30:50PM +0900, Takahashi Tomohiro wrote: > Hi, > > I made the patch that corrected the following problem. > > It is that when I executed the "virsh detach-disk" command on Xen3.3.1, > Libvirt could not detach tap device and output the following error > message. > > # virsh detach-disk Fedora xvdd > libvir: Xen Daemon error : POST operation failed: xend_post: error > from xen daemon: (xend.err 'Device 51760 not connected') > > The cause of this problem is incompatible of Xen3.3.0 and Xen3.3.1. > I think Xen specific was changed by the following patch. > http://xenbits.xensource.com/xen-3.3-testing.hg?rev/e0e17216ba70 > > If you have any comments, please suggest me. > > Signed-off-by: Tomohiro Takahashi <takatom@xxxxxxxxxxxxxx> Thanks for reminding me about this problem - we've actally been tracking this in BZ too. https://bugzilla.redhat.com/show_bug.cgi?id=475791 There's a patch in that bug which does basically the same thing as yours, but with STREQ & an additional check to avoid NULL dereference Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list