Re: [PATCH 7/9] tests: utils: Add PreFormat callback for CompareXML2XML helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/09/2016 10:55 AM, Martin Kletzander wrote:
> On Thu, Jan 28, 2016 at 03:30:12PM -0500, Cole Robinson wrote:
>> This allows individual driver tests to hook in their own code before
>> the def is formatted and compared.
>>
>> We will eventually use this in the qemuxml2xml
>> ---
>> tests/bhyvexml2xmltest.c   | 3 ++-
>> tests/genericxml2xmltest.c | 3 ++-
>> tests/lxcxml2xmltest.c     | 3 ++-
>> tests/qemuxml2xmltest.c    | 6 ++++--
>> tests/testutils.c          | 7 ++++++-
>> tests/testutils.h          | 6 +++++-
>> 6 files changed, 21 insertions(+), 7 deletions(-)
>>
> 
> Visual ACK to 5-7/9, I can't apply them, but if the test work for you,
> then just push them so you don't need to resend them because of those
> last two patches again.  However I would like to see 8/9 applied in
> order to ACK it.  Unless someone else is will beat me to it.

I'm about to send a rebased v2, please give those a spin

Thanks,
Cole

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]