Re: [PATCH 1/7] gic: Introduce virGICVersion enumeration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/03/2016 03:25 PM, Andrea Bolognani wrote:
> We currently blindly accept any numeric value as a GIC version, even
> thought only GIC v2 and GIC v3 actually exist; on the other hand, we
> reject "host", which is a perfectly legitimate value for QEMU guests.
> 
> This new enumeration contains all GIC versions libvirt is aware of.
> ---
>  src/Makefile.am   |  1 +
>  src/util/virgic.c | 33 +++++++++++++++++++++++++++++++++
>  src/util/virgic.h | 38 ++++++++++++++++++++++++++++++++++++++
>  3 files changed, 72 insertions(+)
>  create mode 100644 src/util/virgic.c
>  create mode 100644 src/util/virgic.h
> 

Seems a bit overkill to give this its own util/ file, but I assume this may
grow extra host probing bits in the future?

Thanks,
Cole

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]