Check for return values of libvirt's internal APIs in vboxDumpVideo and vboxDumpDisplay. Patch 10/13 should fix a complaint by Coverity (untested). Lots of whitespace changes, -b is your friend. Ján Tomko (13): Check return value of vboxDumpVideo vboxDumpDisplay: reduce indentation level vboxDumpDisplay: more indentation reducing vboxDumpDisplay: add addDesktop bool vboxDumpDisplay: remove extra virReportOOMError vboxDumpDisplay: split out def->graphics allocation vboxDumpDisplay: allocate the graphics structure upfront vboxDumpDisplay: fill out the graphics structure earlier vboxDumpDisplay: clean up VIR_STRDUP usage vboxDumpDisplay: check return of virDomainGraphicsListenSetAddress vboxDumpDisplay: use VIR_APPEND_ELEMENT vboxDumpDisplay: reuse the keyUtf16 variable vboxDumpDisplay: remove suspicious strlen src/vbox/vbox_common.c | 249 ++++++++++++++++++++++--------------------------- 1 file changed, 113 insertions(+), 136 deletions(-) -- 2.4.10 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list