Re: [PATCH RFC v2 0/5] conf: add net device prefix capability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 03, 2016 at 09:40:32PM +0000, Joao Martins wrote:
> Hey,
> 
> Back in the pre 1.3.0 release [0] we had a regression when migrating
> domains in libxl (introduced by the reverted commit d2e5538b1).
> 
> The chosen solution to address this problem was to introduce a
> capability to be used by the virDomainNetDefFormat() and
> virDomainNetDefParseXML() routines. RFCv1 implemented this by "caching"
> netprefix in the domain definition[1]; as suggested in the review[1] v2
> implements it by adding the virCapsPtr to the relevant APIs and also
> propagating the API change to all drivers. It is divided as follows:
> 
> 	Patch 1: Adds prefix to capabilites
> 	Patch 2: Add prefix to NetDefParseXML
> 	Patch 3,4: API changes to include virCapsPtr and netprefix (New)
> 	Patch 5: set prefix on libxl (Acked)
> 
> Having this series and the reverted commit applied, I can
> successfully migrate a domain without seeing the same interface
> name on both source and destination node with libxl.
> 
> Note: I haven't been able to compile-test all drivers, specifically bhyve,
> vz and hyperv. Testing was made with libxl.

I fixed smalls in the vs & hyperv drivers and pushed this series.

I'll send a followup for the virDomainObjFormat / virDomainSaveStatus
additions.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]