Re: [PATCH v2 00/21] vcpu info storage refactors - part 2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 29, 2016 at 05:01:55PM +0100, Peter Krempa wrote:
> Some of patches were pushed. The rest fixes most of the feedback that made
> sense that was against v1.
> 
> Peter Krempa (21):
>   cgroup: Clean up virCgroupGetPercpuStats
>   conf: Add helper to retrieve bitmap of active vcpus for a definition
>   cgroup: Prepare for sparse vCPU topologies in virCgroupGetPercpuStats
>   qemu: cpu hotplug: Set vcpu state directly in the new structure
>   qemu: Move and rename qemuProcessDetectVcpuPIDs to
>     qemuDomainDetectVcpuPids
>   qemu: domain: Prepare qemuDomainDetectVcpuPids for reuse
>   qemu: Reuse qemuDomainDetectVcpuPids in cpu hot(un)plug
>   conf: Don't copy def->cpumask into cpu pinning info
>   conf: Split out logic to determine whether cpupin was provided
>   conf: Store cpu pinning data in def->vcpus
>   conf: remove unused cpu pinning helpers and data structures
>   conf: Extract code that formats <cputune>
>   util: bitmap: Introduce bitmap subtraction
>   conf: Add helper to return a bitmap of active iothread ids
>   conf: Extract code for parsing thread resource scheduler info
>   conf: Don't store vcpusched orthogonally to other vcpu info
>   conf: Fix how iothread scheduler info is stored
>   qemu: vcpu: Aggregate code to set vCPU tuning
>   qemu: vcpu: Reuse qemuProcessSetupVcpu in vcpu hotplug
>   qemu: iothread: Aggregate code to set IOTrhead tuning
>   qemu: iothread: Reuse qemuProcessSetupIOThread in iothread hotplug
> 
>  src/conf/domain_conf.c                             | 940 +++++++++++----------
>  src/conf/domain_conf.h                             |  45 +-
>  src/libvirt_private.syms                           |  10 +-
>  src/libxl/libxl_domain.c                           |  20 +-
>  src/libxl/libxl_driver.c                           |  41 +-
>  src/lxc/lxc_driver.c                               |   2 +-
>  src/qemu/qemu_cgroup.c                             | 195 -----
>  src/qemu/qemu_cgroup.h                             |   2 -
>  src/qemu/qemu_domain.c                             |  84 ++
>  src/qemu/qemu_domain.h                             |   2 +
>  src/qemu/qemu_driver.c                             | 405 +++------
>  src/qemu/qemu_process.c                            | 478 ++++++-----
>  src/qemu/qemu_process.h                            |   6 +
>  src/test/test_driver.c                             |  45 +-
>  src/util/virbitmap.c                               |  21 +
>  src/util/virbitmap.h                               |   3 +
>  src/util/vircgroup.c                               |  74 +-
>  src/util/vircgroup.h                               |   3 +-
>  src/vz/vz_sdk.c                                    |   4 +-
>  .../qemuxml2xmlout-cputune-iothreadsched.xml       |   3 +-
>  tests/virbitmaptest.c                              |  55 ++
>  tests/vircgrouptest.c                              |   2 +-
>  22 files changed, 1148 insertions(+), 1292 deletions(-)
> 

I have ACKed all the patches except 3,7,10.
Patches 16 18 and 20 need some fixing,
for 9 and 19 touching up the commit message would be nice
and I requested another patch while looking at patch 15.

Jan

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]