Re: [PATCH v2 15/21] conf: Extract code for parsing thread resource scheduler info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 29, 2016 at 05:02:10PM +0100, Peter Krempa wrote:
> As the scheduler info elements are represented orthogonally to how it
> makes sense to actually store the information, the extracted code will
> be later used when converting between XML and internal definitions.
> ---
> 
> Notes:
>     v2: tweaked spelling in error message
> 
>  src/conf/domain_conf.c | 69 ++++++++++++++++++++++++++++++++------------------
>  1 file changed, 45 insertions(+), 24 deletions(-)
> 

ACK

> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -14522,36 +14522,34 @@ virDomainLoaderDefParseXML(xmlNodePtr node,
> +static virBitmapPtr
> +virDomainSchedulerParse(xmlNodePtr node,
> +                        const char *name,
> +                        virProcessSchedPolicy *policy,
> +                        int *priority)
>  {
> +    virBitmapPtr ret = NULL;
>      char *tmp = NULL;
>      int pol = 0;
> 
> -    tmp = virXMLPropString(node, name);
> -    if (!tmp) {
> +    if (!(tmp = virXMLPropString(node, name))) {
>          virReportError(VIR_ERR_XML_ERROR,
>                         _("Missing attribute '%s' in element '%sched'"),

This message could also use an extra 's'.

Jan

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]