Re: [PATCH v2 01/21] cgroup: Clean up virCgroupGetPercpuStats

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 29, 2016 at 05:01:56PM +0100, Peter Krempa wrote:
> Use 'ret' for return variable name, clarify use of 'param_idx' and avoid
> unnecessary 'success' label. No functional changes. Also document the
> function.
> ---
> 
> Notes:
>     V2:
>     - Fixed mistake in the refactor that would return incorrect error values (Found by Jan)
>     - Added comment explaining the terriblenes of the function (Requested by John)
> 
>  src/util/vircgroup.c | 64 +++++++++++++++++++++++++++++++++++-----------------
>  1 file changed, 43 insertions(+), 21 deletions(-)
> 

ACK

Jan

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]